[Check_postgres-commit] [commit] More Perl::Critic tweaks

check_postgres at bucardo.org check_postgres at bucardo.org
Wed Jun 3 01:00:22 UTC 2009


Committed by Greg <greg at core.localdomain>

More Perl::Critic tweaks

---
 .perlcriticrc     |    1 +
 Makefile.PL       |    2 +-
 check_postgres.pl |    4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.perlcriticrc b/.perlcriticrc
index 2645ed9..0237e91 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -38,6 +38,7 @@ stop_words = Mullane Nagios Slony nols salesrep psql dbname postgres USERNAME us
 [-Miscellanea::RequireRcsKeywords]
 [-Modules::ProhibitExcessMainComplexity]
 [-Modules::RequireExplicitInclusion]
+[-Modules::RequireFilenameMatchesPackage]
 [-NamingConventions::Capitalization]
 [-NamingConventions::ProhibitAmbiguousNames]
 [-NamingConventions::ProhibitMixedCaseVars]
diff --git a/Makefile.PL b/Makefile.PL
index b9f79fa..7ef5a6f 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -57,7 +57,7 @@ my %opts =
 );
 
 {
-	package MY; ## no critic
+	package MY;
 	sub clean { ## no critic (RequireArgUnpacking)
 		my $string = shift->SUPER::clean(@_);
 		$string =~ s{\t}{\tperl t/99_cleanup\.t\n\t};
diff --git a/check_postgres.pl b/check_postgres.pl
index a3c60b3..3725c43 100755
--- a/check_postgres.pl
+++ b/check_postgres.pl
@@ -4262,10 +4262,10 @@ sub check_same_schema {
 					push @{$filter{"no${type}_regex"}} => $1;
 				}
 			}
-			if ($phrase =~ /^noposition$/io) {
+			if ($phrase =~ /^noposition$/io) { ## no critic (ProhibitFixedStringMatches)
 				$filter{noposition} = 1;
 			}
-			if ($phrase =~ /^nofuncbody$/io) {
+			if ($phrase =~ /^nofuncbody$/io) { ## no critic (ProhibitFixedStringMatches)
 				$filter{nofuncbody} = 1;
 			}
 		}
-- 
1.6.2.2



More information about the Check_postgres-commit mailing list